Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Paul Menzel, Tarun.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79330?usp=email )
Change subject: mb/google/rex/var/screebo: Override power limits ......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79330/comment/b1ec49ef_ddadd24c : PS3, Line 21: [INFO ] Overriding power limits PL1 (mW) (10000, 15000) : PL2 (mW) (40000, 40000) PL4 (W) (84) : : After: : : [INFO ] Overriding power limits PL1 (mW) (10000, 15000) : PL2 (mW) (40000, 40000) PL4 (W) (84)
The values are unchanged?
yes, that's because we are now overriding the same value (previously used to override by baseboard) from a variant directory. This will help in future variants design to override the baseboard aka default (which might be the case with Screebo).
The CB:79331 ensures that baseboard can only program the default PL limits which is performance oriented and variants can override the defaults with something that is more appropriate from the design standpoint.
With CB:79330 and CB:79331, we will see that Rex is baseboard supporting performance design limits but screebo would override with power efficient design PL value.
I hope it clarifies your doubt