2 comments:
File src/soc/intel/tigerlake/chip.h:
Patch Set #2, Line 126: 0: FSP default(Max), 1: Disable, 2: L1.1 3: L1.2 4:Max
Could this be an enum? It would make the devicetree options less confusing
Ack
File src/soc/intel/tigerlake/fsp_params_tgl.c:
if (config->PcieRpL1Substates[i])
params->PcieRpL1Substates[i] = config->PcieRpL1Substates[i] - 1;
I don't know if this will work as intended. […]
This is verified. if we don't assign, FSP use default values.
But for safe( in case new FSP change default value), it's better assign value.
And I think it's better not use MAX(3) as it means same as 2(L1.2) for avoiding confusion.
I'll update code to use enum value.
To view, visit change 39412. To unsubscribe, or for help writing mail filters, visit settings.