Kyösti Mälkki has uploaded this change for review.
intel/haswell,broadwell,fsp_broadwell_de: Drop unused parameter
Change-Id: I3f2c89f1b7d5980640cceca02a25d2903b17a78c
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
---
M src/cpu/intel/haswell/smmrelocate.c
M src/soc/intel/broadwell/smmrelocate.c
M src/soc/intel/fsp_broadwell_de/smmrelocate.c
3 files changed, 6 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/34746/1
diff --git a/src/cpu/intel/haswell/smmrelocate.c b/src/cpu/intel/haswell/smmrelocate.c
index ca2c68f..a9954ec 100644
--- a/src/cpu/intel/haswell/smmrelocate.c
+++ b/src/cpu/intel/haswell/smmrelocate.c
@@ -210,8 +210,7 @@
}
}
-static void fill_in_relocation_params(struct device *dev,
- struct smm_relocation_params *params)
+static void fill_in_relocation_params(struct smm_relocation_params *params)
{
uintptr_t tseg_base;
size_t tseg_size;
@@ -290,11 +289,9 @@
void smm_info(uintptr_t *perm_smbase, size_t *perm_smsize,
size_t *smm_save_state_size)
{
- struct device *dev = pcidev_on_root(0, 0);
-
printk(BIOS_DEBUG, "Setting up SMI for CPU\n");
- fill_in_relocation_params(dev, &smm_reloc_params);
+ fill_in_relocation_params(&smm_reloc_params);
setup_ied_area(&smm_reloc_params);
diff --git a/src/soc/intel/broadwell/smmrelocate.c b/src/soc/intel/broadwell/smmrelocate.c
index 7e893c1..981b42b 100644
--- a/src/soc/intel/broadwell/smmrelocate.c
+++ b/src/soc/intel/broadwell/smmrelocate.c
@@ -179,8 +179,7 @@
}
}
-static void fill_in_relocation_params(struct device *dev,
- struct smm_relocation_params *params)
+static void fill_in_relocation_params(struct smm_relocation_params *params)
{
uintptr_t tseg_base;
size_t tseg_size;
@@ -251,11 +250,9 @@
void smm_info(uintptr_t *perm_smbase, size_t *perm_smsize,
size_t *smm_save_state_size)
{
- struct device *dev = pcidev_path_on_root(SA_DEVFN_ROOT);
-
printk(BIOS_DEBUG, "Setting up SMI for CPU\n");
- fill_in_relocation_params(dev, &smm_reloc_params);
+ fill_in_relocation_params(&smm_reloc_params);
setup_ied_area(&smm_reloc_params);
diff --git a/src/soc/intel/fsp_broadwell_de/smmrelocate.c b/src/soc/intel/fsp_broadwell_de/smmrelocate.c
index 3086acb..a7b06dc 100644
--- a/src/soc/intel/fsp_broadwell_de/smmrelocate.c
+++ b/src/soc/intel/fsp_broadwell_de/smmrelocate.c
@@ -190,8 +190,7 @@
write_prmrr(relo_params);
}
-static void fill_in_relocation_params(pci_devfn_t dev,
- struct smm_relocation_params *params)
+static void fill_in_relocation_params(struct smm_relocation_params *params)
{
uintptr_t tseg_base;
size_t tseg_size;
@@ -261,11 +260,9 @@
void smm_info(uintptr_t *perm_smbase, size_t *perm_smsize,
size_t *smm_save_state_size)
{
- pci_devfn_t dev = PCI_DEV(BUS0, VTD_DEV, VTD_FUNC);
-
printk(BIOS_DEBUG, "Setting up SMI for CPU\n");
- fill_in_relocation_params(dev, &smm_reloc_params);
+ fill_in_relocation_params(&smm_reloc_params);
setup_ied_area(&smm_reloc_params);
To view, visit change 34746. To unsubscribe, or for help writing mail filters, visit settings.