Attention is currently required from: Furquan Shaikh, Angel Pons, EricR Lai.
5 comments:
File src/soc/intel/alderlake/romstage/fsp_params.c:
Patch Set #34, Line 25: convert_
nit: convert_ seems unncessary, clk_src_to_fsp sounds good enough
PCIE_CLK_FREE
Patch Set #34, Line 44: CpuPcieRpEnableMask
This still needs to be mapped to the 3 RPs
return m_cfg->PcieRpEnableMask & BIT(rp_number);
if (type == CPU_PCIE_RP)
return m_cfg->CpuPcieRpEnableMask;
Instead of requiring the user to have written into `m_cfg` before calling this function, why not have this function take a `uint32_t` that is the mask instead?; the caller already knows whether it's CPU or PCH.
File src/soc/intel/common/block/include/intelblocks/pcie_rp.h:
okay, make sense.
Sorry what I mean is using PCI_CLK_FREE in a devicetree (or code) makes the code easier to read; agree with Angel, leave this comment as `/* Clock source is free running */`.
To view, visit change 48340. To unsubscribe, or for help writing mail filters, visit settings.