Attention is currently required from: Yidi Lin.
View Change
1 comment:
Commit Message:
Patch Set #11, Line 15: counter should never be that fast.
Oh okay, yeah, then we need to do something. Which platform did he see it on? […]
gcd64() would fix the regression, I'm ok with that. Though, in the long run,
we should still fix the original overflow for the general case. I can also
look into that.
To view, visit change 78888. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia55532490651fcf47128b83a8554751f050bcc89
Gerrit-Change-Number: 78888
Gerrit-PatchSet: 11
Gerrit-Owner: Yidi Lin <yidilin@google.com>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Yidi Lin <yidilin@google.com>
Gerrit-Comment-Date: Tue, 06 Feb 2024 22:53:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Julius Werner <jwerner@chromium.org>
Gerrit-MessageType: comment