Patch Set 5:
Hi Patrick,
The new implementation for "tpm presence query" is broken. We use the TPM presence to differentiate between EVB and Proto boards(refer CB:32271)
The board_id in the libsysinfo stucture gets filled even before the TPM probe happens in the Ramstage. Hence, the dts for EVB boards is selected consistently in depthcharge because of the wrong board id.Thanks,
Nitheesh Sekar
https://review.coreboot.org/c/coreboot/+/32271/8/src/mainboard/google/mistral/boardid.c#37 should ensure that the TPM is initialized early enough. There are other issues that prevent me from completely testing it right now, but the preliminary results look good so I put it out there. please test with that update.
To view, visit change 31898. To unsubscribe, or for help writing mail filters, visit settings.