Attention is currently required from: Andrey Petrov, Arthur Heymans, Chen, Gang C, David Hendricks, Johnny Lin, Lean Sheng Tan, Paul Menzel, Ronak Kanabar, Shuo Liu.
View Change
2 comments:
Commit Message:
Patch Set #1, Line 9:
FSP allocates temporary ram in its reserved memory ranges
instead of requesting coreboot to do the allocation. This
is supported by some FSP implementations for Xeon SP.
Are you sure that is what is going on? It's just using the default settings which avoid this heap be […]
I second this. If we used the defaults, we would still have to assert that
they are in a range compatible to the current coreboot state. Otherwise, we
would risk bugs when something in coreboot changes (within limits of the FSP
spec). Writing such checks is probably more work then setting correct values
in the first place. But I would have to see the memory map first to be able
to tell.
Patchset:
Patch Set #3:
I hope we are not stuck here. Shuo, if you could draw a small temp-ram memory
map that would be incredibly helpful. Doesn't have to be fancy, some ascii-art
in the style of [1] would be perfect. It could live in the Kconfig help text,
for instance. We need to get all in sync about what is going on to find a suitable
solution.
[1] soc/intel/common/block/systemagent/memmap.c
To view, visit change 80328. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I17a73e4f627c91808ed17c712b72937662ae9293
Gerrit-Change-Number: 80328
Gerrit-PatchSet: 3
Gerrit-Owner: Shuo Liu <shuo.liu@intel.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Chen, Gang C <gang.c.chen@intel.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin@wiwynn.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan@9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Martin L Roth <gaumless@gmail.com>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Chen, Gang C <gang.c.chen@intel.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin@wiwynn.com>
Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: David Hendricks <david.hendricks@gmail.com>
Gerrit-Attention: Shuo Liu <shuo.liu@intel.com>
Gerrit-Attention: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Attention: Lean Sheng Tan <sheng.tan@9elements.com>
Gerrit-Attention: Ronak Kanabar <ronak.kanabar@intel.com>
Gerrit-Attention: Andrey Petrov <andrey.petrov@gmail.com>
Gerrit-Comment-Date: Fri, 09 Feb 2024 10:55:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-MessageType: comment