3 comments:

File src/arch/x86/acpi.c:
- Patch Set #4, Line 1253: __weak void soc_residency_counter(struct acpi_lpit_native *lpit_native)
  Yeah, for constant information like this, I think I'd rather just use #defines, but I like the table […]
  To summarize i will only keep the function like acpi_create_lpit_generator here which would call a weak soc function. SOC function in turn would return the table of lpit_entries and would use macros for all the MSR's/addresses.
- Patch Set #4, Line 1292: soc_residency_counter(&lpit->lpit_native);
  as mentioned above; don't use a single function for setting just one static struct; instead let's us […]
  Will do.
- Patch Set #4, Line 1294:
```
	lpit->lpit_native.residency = 0;
	lpit->lpit_native.latency = 0;
```
  why are we resetting these values to 0 here, when the socs set them?
  Will Fix

To view, visit change 32350. To unsubscribe, or for help writing mail filters, visit settings.