Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32350 )
Change subject: src/arch/x86:Add support for low power idle table ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/32350/4/src/arch/x86/acpi.c File src/arch/x86/acpi.c:
https://review.coreboot.org/c/coreboot/+/32350/4/src/arch/x86/acpi.c@1253 PS4, Line 1253: __weak void soc_residency_counter(struct acpi_lpit_native *lpit_native)
Yeah, for constant information like this, I think I'd rather just use #defines, but I like the table […]
To summarize i will only keep the function like acpi_create_lpit_generator here which would call a weak soc function. SOC function in turn would return the table of lpit_entries and would use macros for all the MSR's/addresses.
https://review.coreboot.org/c/coreboot/+/32350/4/src/arch/x86/acpi.c@1292 PS4, Line 1292: soc_residency_counter(&lpit->lpit_native);
as mentioned above; don't use a single function for setting just one static struct; instead let's us […]
Will do.
https://review.coreboot.org/c/coreboot/+/32350/4/src/arch/x86/acpi.c@1294 PS4, Line 1294: lpit->lpit_native.residency = 0; : lpit->lpit_native.latency = 0; :
why are we resetting these values to 0 here, when the socs set them?
Will Fix