Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Jérémy Compostella, Matt DeVillier, Patrick Rudolph.
View Change
1 comment:
Commit Message:
Patch Set #1, Line 9: When switching back and forward from 32 to 64, for example to call a
I don't understand this. Where's the relation between protected mode calls and linking page tables into the stage?
Doesn't this increase the stage size and thus occupies more flash in the end? That should be mentioned here as well.
What's the benefit of linking instead over having it in CBFS?
Your right it should be mentioned why. With a VBOOT setup you don't want to rely on the RO path for things on the RW path. It does increase the size. Most targets since 2010 should have gigabyte pages so a follow-up could reduce the size increase a lot. Also with your patches to set up pages at runtime it could not end up in a flash size increase.
To view, visit change 80337. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ied54b66b930187cba5fbc578a81ed5859a616562
Gerrit-Change-Number: 80337
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred@gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk@gmail.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella@intel.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Gerrit-CC: Martin L Roth <gaumless@gmail.com>
Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-CC: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk@gmail.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella@intel.com>
Gerrit-Attention: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred@gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Comment-Date: Mon, 05 Feb 2024 08:41:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-MessageType: comment