>> 1. don't define ASSERT() in assert.h (e.g. rename it to _ASSERT()). existing calls should call the standard assert()
>
> I think that wouldn't be a bad change (we should standardize on assert() and have nothing else), but I think other files in coreboot shouldn't make up their own ASSERT() either.
Ok, let's keep that in mind. I guess, we don't need it here,
see below.
Note that that's only half the issues, there's also https://qa.coreboot.org/job/coreboot-gerrit/87667/testReport/junit/board/chromeos/GOOGLE_GRU/ which I'm not quite sure about. It seems to be some weird include path problem with vboot (and maybe a hint that we shouldn't implement all our string functions as static inlines in headers anyway... why are we doing that?).
So strategy from here, move the bigger implementations into
their own compilation unit? I wouldn't mind keeping some of
the lighter functions inline. But would we then add the new
compilation unit to romstage just for the `dead_code` mes-
sage?
To view, visit change 30844. To unsubscribe, or for help writing mail filters, visit settings.