Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34872 )
Change subject: google/kukui: Load and run dram init blob
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34872/3/src/mainboard/google/kukui/...
File src/mainboard/google/kukui/romstage.c:
https://review.coreboot.org/c/coreboot/+/34872/3/src/mainboard/google/kukui/...
PS3, Line 37: dram.bin
We treat the blob as a prog (stage type / elf format), and prog_run() return void now. […]
Ack, thank you for taking this into account
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34872
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad05a77e6353f37cd5ea897203d528762f44176e
Gerrit-Change-Number: 34872
Gerrit-PatchSet: 5
Gerrit-Owner: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: SJ Huang
sj.huang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Thu, 29 Aug 2019 13:04:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-MessageType: comment