Attention is currently required from: Shelley Chen, Sumeet R Pawnikar. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81789?usp=email ) Change subject: mb/google/brox: Initialize NOTE_BOOK_MODE GPIO ...................................................................... Patch Set 6: Code-Review+2 (1 comment) File src/mainboard/google/brox/variants/baseboard/brox/gpio.c: https://review.coreboot.org/c/coreboot/+/81789/comment/74ff79af_e97c3025 : PS5, Line 202: PAD_CFG_NF(GPP_E9, NONE, PLTRST, NF2),
Done Thanks. Your understanding is correct.
-- To view, visit https://review.coreboot.org/c/coreboot/+/81789?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4a091b58deb855c7a7f1489a9506db2f821503b7 Gerrit-Change-Number: 81789 Gerrit-PatchSet: 6 Gerrit-Owner: Shelley Chen <shchen@google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub@google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro@google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Shelley Chen <shchen@google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com> Gerrit-Comment-Date: Thu, 11 Apr 2024 17:58:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Shelley Chen <shchen@google.com> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub@google.com> Gerrit-MessageType: comment