Patch set 21:Code-Review +1
5 comments:
Patch Set #21, Line 14: driver
nit: this should go to the next line
Patch Set #21, Line 15: wouldn't been have hidden
wouldn't have been hidden
File src/soc/intel/common/block/uart/chip.h:
SPDX-License-Identifier: GPL-2.0-only */
#include <stdint.h>
Jenkins seems not to care.
It's just for aesthetics
Patch Set #21, Line 3: device/pci_ids.h
It is. See commit message.
Maybe add a comment to let people know this is so that mainboards can use these definitions in the devicetree?
File src/soc/intel/common/block/uart/uart.c:
Patch Set #21, Line 284: strncmp
strcmp, maybe?
IMHO another switch-case like that of `uart_acpi_hid` would be cleaner
To view, visit change 40405. To unsubscribe, or for help writing mail filters, visit settings.