View Change
1 comment:
Commit Message:
Patch Set #3, Line 7: skl,icl,cnl
I would like to see why APL/GLK is different and what are the factors that make it a bad fit for thi […]
It is not the case of a bad fit. The patch is just moving some function definitions that are identical across SoC to a common location. For APL/GLK the function definitions are not same.
Now, APL/GLK can be also be included in a common code model by making early init sequence as part of some common functions across SoCs which is being done in the pathset that I noted previously.
To view, visit change 35277. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id7c563023c4b1ff4f42734f18b923d13afef4770
Gerrit-Change-Number: 35277
Gerrit-PatchSet: 3
Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi@intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi@intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Wed, 11 Sep 2019 17:26:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rizwan Qureshi <rizwan.qureshi@intel.com>
Comment-In-Reply-To: Furquan Shaikh <furquan@google.com>
Gerrit-MessageType: comment