Attention is currently required from: Paul Menzel, Stefan Reinauer, Angel Pons, Kyösti Mälkki. Jeff Daly has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60736 )
Change subject: util/ifdtool: Add additional regions for platforms that support them ......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60736/comment/2f92f464_8c920c99 PS4, Line 9:
nit: trailing space
Ack
https://review.coreboot.org/c/coreboot/+/60736/comment/2f1a2979_14a4a62e PS4, Line 10: FW
I'd spell out `firmware` here for consistency with `Innovation Engine firmware`
Ack
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/60736/comment/7f9500ae_673b4eb5 PS4, Line 43: SI_DEV_EXP1
These are the names for the corresponding FMAP (.fmd files in the coreboot tree) regions. […]
can do.
https://review.coreboot.org/c/coreboot/+/60736/comment/ec2a8850_ddb177c4 PS4, Line 43: Expansion1
Are there more "Device Expansion" regions? If not, I'd remove the `1` from here.
yes, LBG has Device Expansion 2 in flash region 9. Which I can add.