Patch Set 4: Code-Review-1

I'm not sure if we really want to enable CSE/ME/... by default

I'd rather have a board with CSTXE HECI visible from the OS than a board that may get stuck when trying to perform a global reset. Since the device is missing from the devicetree, attempting a global reset before PCI enumeration took place would result in a `dev is NULL!` halt message.

If CSTXE is not functioning normally, FSP usually hides its PCI device. Unless any user of these boards really wants the CSTXE to remain disabled, I think this patch is good to go. If there are any complaints, we can just report the device as disabled in the devicetree.

Patch set 4:Code-Review +2

View Change

To view, visit change 45469. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I97d221ae52b4b03ecd859d708847ad77fe4bf465
Gerrit-Change-Number: 45469
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Elyes HAOUAS
Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh@gmail.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer@siemens.com>
Gerrit-Reviewer: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Subrata Banik <subi.banik@gmail.com>
Gerrit-Comment-Date: Thu, 17 Sep 2020 19:32:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment