5 comments:
File src/drivers/intel/fsp1_1/exit_car.S:
Patch Set #28, Line 23: andl $0xfffffff0, %esp
The stack needs to be 16 byte aligned upon entry into C. There need to be 3 pushes prior to push %ebx. And similar on the pop for stack balance.
Patch Set #28, Line 28: pop %ebx
What is the purpose of ebx saving? Isn't the stack contents migrated? If not, who is managing the value?
File src/drivers/intel/fsp1_1/romstage.c:
Patch Set #28, Line 95: #if IS_ENABLED(CONFIG_HAVE_SMI_HANDLER)
Can't we make this a normal if() ?
File src/drivers/intel/fsp1_1/temp_ram_exit.c:
Patch Set #28, Line 23: fih = NULL;
if we're dying why set fih to NULL?
Patch Set #28, Line 28: fih = find_fsp((uintptr_t)rdev_mmap_full(prog_rdev(&fsp)));
Should we sanity check fih is not bad?
To view, visit change 30686. To unsubscribe, or for help writing mail filters, visit settings.