6 comments:
BUG=?
BRANCH=hatch
TEST=
File src/mainboard/google/hatch/variants/baseboard/gpio.c:
Can you do a git blame on this to see why it was set to 1 in the first place? I am suspecting if there was some power leakage that was observed in S5?
*num = ARRAY_SIZE(default_sleep_gpio_table);
return default_sleep_gpio_table;
This can just be:
*num = 0;
return NULL;
since default_sleep_gpio_table is just empty.
File src/mainboard/google/hatch/variants/helios/gpio.c:
Patch Set #2, Line 161: if (slp_typ == ACPI_S5) {
are you fixing s5 or s3? I thought that you were fixing entering/exiting s3.
I believe Craig wants to disable the pads only when entering S5 and leave as is when going to S3.
*num = ARRAY_SIZE(sleep_gpio_table);
return sleep_gpio_table;
Same comment as baseboard.
File src/mainboard/google/hatch/variants/kohaku/gpio.c:
*num = ARRAY_SIZE(sleep_gpio_table);
return sleep_gpio_table;
same comment as baseboard.
To view, visit change 37459. To unsubscribe, or for help writing mail filters, visit settings.