Felix Held submitted this change.

View Change



15 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved
nb/intel/i945: Remove apic 0 from devicetree

This is added at runtime.

Change-Id: I1f684c800de6711d8b0a0aea0d59c8e21d22c14a
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/69299
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/mainboard/apple/macbook21/devicetree.cb
M src/mainboard/asus/p5gc-mx/devicetree.cb
M src/mainboard/getac/p470/devicetree.cb
M src/mainboard/ibase/mb899/devicetree.cb
M src/mainboard/intel/d945gclf/devicetree.cb
M src/mainboard/kontron/986lcd-m/devicetree.cb
M src/mainboard/lenovo/t60/devicetree.cb
M src/mainboard/lenovo/x60/devicetree.cb
M src/mainboard/roda/rk886ex/devicetree.cb
9 files changed, 24 insertions(+), 55 deletions(-)

diff --git a/src/mainboard/apple/macbook21/devicetree.cb b/src/mainboard/apple/macbook21/devicetree.cb
index a7832ef..dd701da 100644
--- a/src/mainboard/apple/macbook21/devicetree.cb
+++ b/src/mainboard/apple/macbook21/devicetree.cb
@@ -13,13 +13,7 @@
register "gpu_panel_power_backlight_off_delay" = "2380"
register "gpu_panel_power_cycle_delay" = "2"

- device cpu_cluster 0 on
- ops i945_cpu_bus_ops
- chip cpu/intel/socket_m
- device lapic 0 on end
- end
- end
-
+ device cpu_cluster 0 on ops i945_cpu_bus_ops end # APIC cluster
register "pci_mmio_size" = "768"

device domain 0 on
diff --git a/src/mainboard/asus/p5gc-mx/devicetree.cb b/src/mainboard/asus/p5gc-mx/devicetree.cb
index 8238826..f6d5f76 100644
--- a/src/mainboard/asus/p5gc-mx/devicetree.cb
+++ b/src/mainboard/asus/p5gc-mx/devicetree.cb
@@ -2,12 +2,7 @@

chip northbridge/intel/i945

- device cpu_cluster 0 on
- ops i945_cpu_bus_ops
- chip cpu/intel/socket_LGA775
- device lapic 0 on end
- end
- end
+ device cpu_cluster 0 on ops i945_cpu_bus_ops end # APIC cluster

device domain 0 on
ops i945_pci_domain_ops
diff --git a/src/mainboard/getac/p470/devicetree.cb b/src/mainboard/getac/p470/devicetree.cb
index 2514ad4..b12335e 100644
--- a/src/mainboard/getac/p470/devicetree.cb
+++ b/src/mainboard/getac/p470/devicetree.cb
@@ -5,12 +5,7 @@
register "gfx.ndid" = "2"
register "gfx.did" = "{ 0x80000100, 0x80000410, 0x80000320, 0x80000410, 0x00000005 }"

- device cpu_cluster 0 on
- ops i945_cpu_bus_ops
- chip cpu/intel/socket_m
- device lapic 0 on end
- end
- end
+ device cpu_cluster 0 on ops i945_cpu_bus_ops end # APIC cluster

register "pci_mmio_size" = "768"

diff --git a/src/mainboard/ibase/mb899/devicetree.cb b/src/mainboard/ibase/mb899/devicetree.cb
index 51ca420..611bd96 100644
--- a/src/mainboard/ibase/mb899/devicetree.cb
+++ b/src/mainboard/ibase/mb899/devicetree.cb
@@ -2,12 +2,7 @@
# IGD Displays
register "gfx" = "GMA_STATIC_DISPLAYS(0)"

- device cpu_cluster 0 on
- ops i945_cpu_bus_ops
- chip cpu/intel/socket_m
- device lapic 0 on end
- end
- end
+ device cpu_cluster 0 on ops i945_cpu_bus_ops end # APIC cluster

register "pci_mmio_size" = "768"

diff --git a/src/mainboard/intel/d945gclf/devicetree.cb b/src/mainboard/intel/d945gclf/devicetree.cb
index 5c72c72..4007e7e 100644
--- a/src/mainboard/intel/d945gclf/devicetree.cb
+++ b/src/mainboard/intel/d945gclf/devicetree.cb
@@ -2,12 +2,7 @@

chip northbridge/intel/i945

- device cpu_cluster 0 on
- ops i945_cpu_bus_ops
- chip cpu/intel/socket_441
- device lapic 0 on end
- end
- end
+ device cpu_cluster 0 on ops i945_cpu_bus_ops end # APIC cluster

register "pci_mmio_size" = "768"

diff --git a/src/mainboard/kontron/986lcd-m/devicetree.cb b/src/mainboard/kontron/986lcd-m/devicetree.cb
index e58d8f3..cd67480 100644
--- a/src/mainboard/kontron/986lcd-m/devicetree.cb
+++ b/src/mainboard/kontron/986lcd-m/devicetree.cb
@@ -2,12 +2,7 @@
# IGD Displays
register "gfx" = "GMA_STATIC_DISPLAYS(0)"

- device cpu_cluster 0 on
- ops i945_cpu_bus_ops
- chip cpu/intel/socket_m
- device lapic 0 on end
- end
- end
+ device cpu_cluster 0 on ops i945_cpu_bus_ops end # APIC cluster

register "pci_mmio_size" = "768"

diff --git a/src/mainboard/lenovo/t60/devicetree.cb b/src/mainboard/lenovo/t60/devicetree.cb
index 7a9e9ae..913b732 100644
--- a/src/mainboard/lenovo/t60/devicetree.cb
+++ b/src/mainboard/lenovo/t60/devicetree.cb
@@ -13,12 +13,7 @@
register "gpu_panel_power_backlight_off_delay" = "2380"
register "gpu_panel_power_cycle_delay" = "2"

- device cpu_cluster 0 on
- ops i945_cpu_bus_ops
- chip cpu/intel/socket_m
- device lapic 0 on end
- end
- end
+ device cpu_cluster 0 on ops i945_cpu_bus_ops end # APIC cluster

register "pci_mmio_size" = "768"

diff --git a/src/mainboard/lenovo/x60/devicetree.cb b/src/mainboard/lenovo/x60/devicetree.cb
index a41749a..d7c86a5 100644
--- a/src/mainboard/lenovo/x60/devicetree.cb
+++ b/src/mainboard/lenovo/x60/devicetree.cb
@@ -13,12 +13,7 @@
register "gpu_panel_power_backlight_off_delay" = "2380"
register "gpu_panel_power_cycle_delay" = "2"

- device cpu_cluster 0 on
- ops i945_cpu_bus_ops
- chip cpu/intel/socket_m
- device lapic 0 on end
- end
- end
+ device cpu_cluster 0 on ops i945_cpu_bus_ops end # APIC cluster

register "pci_mmio_size" = "768"

diff --git a/src/mainboard/roda/rk886ex/devicetree.cb b/src/mainboard/roda/rk886ex/devicetree.cb
index eb0bdcd..a3b00c1 100644
--- a/src/mainboard/roda/rk886ex/devicetree.cb
+++ b/src/mainboard/roda/rk886ex/devicetree.cb
@@ -4,12 +4,7 @@
# IGD Displays
register "gfx" = "GMA_STATIC_DISPLAYS(0)"

- device cpu_cluster 0 on
- ops i945_cpu_bus_ops
- chip cpu/intel/socket_m
- device lapic 0 on end
- end
- end
+ device cpu_cluster 0 on ops i945_cpu_bus_ops end # APIC cluster

register "pci_mmio_size" = "768"


To view, visit change 69299. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1f684c800de6711d8b0a0aea0d59c8e21d22c14a
Gerrit-Change-Number: 69299
Gerrit-PatchSet: 19
Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas@noos.fr>
Gerrit-MessageType: merged