Attention is currently required from: Subrata Banik, Angel Pons, Patrick Rudolph.
1 comment:
File src/soc/intel/skylake/finalize.c:
Patch Set #3, Line 37: p2sb_unhide();
i don't really understand the motivation here. […]
We unconditionally hide P2SB at the end of `pch_finalize_script`, but may conditionally unhide it first if `HeciEnabled == 0`.
P2SB is either hidden or not hidden when `pch_finalize_script` is called. Therefore, either `pch_disable_heci` does both unhide and hide (P2SB was hidden) or `pch_disable_heci` does not need to unhide (P2SB was not hidden).
Testing showed that P2SB is not hidden when `pch_disable_heci` is called. Therefore remove that call. It's mainly a point of clarity.
I can improve the commit message.
To view, visit change 51205. To unsubscribe, or for help writing mail filters, visit settings.