[coreboot-gerrit] [M] Change in coreboot[master]: security/intel/txt: Helper function to disable TXT

[Jérémy Compostella (Code Review)]

Attention is currently required from: Subrata Banik, Sridhar Siricilla, Angel Pons, Lean Sheng Tan, Werner Zeh.

Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71574 )

Change subject: security/intel/txt: Helper function to disable TXT
......................................................................

Patch Set 4:

(2 comments)

File src/include/cpu/x86/msr.h:

https://review.coreboot.org/c/coreboot/+/71574/comment/99579229_56e025e6 
PS4, Line 84: IA32_UNLOCK_LT_MEMORY
This is not about unlocking some LT memory but more like asking LT to remove a memory lock. Therefore, I suggest to call it `IA32_LT_UNLOCK_MEMORY`.

File src/security/intel/txt/txtlib.c:

https://review.coreboot.org/c/coreboot/+/71574/comment/ffcded71_b8e1896e 
PS4, Line 68: to lock 
`s/to lock/to be locked/` ?