only had a brief look, but i like where this is going. splitting the patch into the (pci_)device part and the TB-specific part would be a good, since those two are separate changes

View Change


To view, visit change 35946. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I500191626584b83e6a8ae38417fd324b5e803afc
Gerrit-Change-Number: 35946
Gerrit-PatchSet: 1
Gerrit-Owner: Jeremy Soller <>
Gerrit-Reviewer: Jeremy Soller <>
Gerrit-Reviewer: Martin Roth <>
Gerrit-Reviewer: Patrick Georgi <>
Gerrit-Reviewer: build bot (Jenkins) <>
Gerrit-CC: Aaron Durbin <>
Gerrit-CC: Brandon Breitenstein <>
Gerrit-CC: Divya S Sasidharan <>
Gerrit-CC: Duncan Laurie <>
Gerrit-CC: Felix Held <>
Gerrit-CC: Furquan Shaikh <>
Gerrit-CC: Kyösti Mälkki <>
Gerrit-CC: Matt DeVillier <>
Gerrit-CC: Mimoja <>
Gerrit-CC: Nathaniel L Desimone <>
Gerrit-CC: Nico Huber <>
Gerrit-CC: Patrick Rudolph <>
Gerrit-CC: Paul Menzel <>
Gerrit-CC: Subrata Banik <>
Gerrit-Comment-Date: Fri, 11 Oct 2019 09:39:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin <>
Comment-In-Reply-To: Patrick Rudolph <>
Comment-In-Reply-To: Nico Huber <>
Gerrit-MessageType: comment