Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32551 )
Change subject: soc/amd/stoneyridge: Correct bugs in lpc.c
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32551/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32551/1//COMMIT_MSG@12
PS1, Line 12: Since the bridge is enabled in bootblock to allow port 80h,
: there is no need to maintain it in ramstage.
I'm ok with that for Stoney, although adding a comment to that effect would probably be good.
For Picasso, are we just going to assume that the ABL has already enabled it?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32551
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I078be974dc3c78c94cb7c0832518f21bac029ff2
Gerrit-Change-Number: 32551
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 03 May 2019 15:45:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment