Thanks for addressing the comments, Mike. I think this can go in after addressing the things in cmos.layout and after Balázs replies to the other comments :)
Patch set 32:Code-Review +1
2 comments:
File src/mainboard/asus/a88xm-e/cmos.layout:
Patch Set #31, Line 32: 456 1 e 1 ECC_memory
Mistake borrowed from F2A85-M. […]
The unused entries can be removed. In any case, it would be very nice to document the syntax of cmos options
Patch Set #31, Line 47: 6 5 Notice
Mistake borrowed from F2A85-M. […]
I pulled these out of mb/asus/p8h61-m_pro/cmos.layout:
6 0 Emergency
6 1 Alert
6 2 Critical
6 3 Error
6 4 Warning
6 5 Notice
6 6 Info
6 7 Debug
6 8 Spew
To view, visit change 30987. To unsubscribe, or for help writing mail filters, visit settings.