Attention is currently required from: Eric Lai, Ivy Jian, Nick Vaccaro, Paul Menzel.

View Change

5 comments:

• Commit Message:

  • Patch Set #4, Line 10: was causing some leakage

    Was it measured?

    Yes it was.

  • Patch Set #4, Line 10:

    Configuring it to 0 initially in
    romstage should fix this.
    

    s/should fix/fixes/ […]

    Done

  • Patch Set #4, Line 11:

    Also, make sure that EN_PP3300_TCHSCR is
    initialized in romstage as well.
    

    Why?

    Because if the reset value is initialized the enable value should be initialized to a proper value.

  • Patch Set #4, Line 13:

    What does the schematic say?

    I do not understand what you are referring to. What does the schematic say about what?

• Patchset:

  • Patch Set #4:

    This is from our HW engineer (Charlie Costakis): "My understanding is that PLT_RST_L is actually the […]

    Marking resolved unless there is still something in question?

To view, visit change 80300. To unsubscribe, or for help writing mail filters, visit settings.