View Change

6 comments:

• File src/soc/qualcomm/sdm845/Kconfig:

  • Patch Set #76, Line 38:

    Convention is to indent 2 spaces here, not a tab (don't ask me why... […]

    Done

• File src/soc/qualcomm/sdm845/include/soc/qcom_qup_se.h:

  • Patch Set #76, Line 469:

    I'm not understanding this comment.
    This struct is required.

• File src/soc/qualcomm/sdm845/uart.c:

  • Patch Set #76, Line 76: GENI_STATUS_S_GENI_CMD_ACTIVE_MASK)

    Fits on one line now? (If not, please align with opening parenthesis. […]

    Done

  • Patch Set #76, Line 130: (unsigned char)

    nit: unnecessary cast (I think?)

    Done

  • Patch Set #76, Line 143: (unsigned int)

    nit: unnecessary cast

    Done

  • Patch Set #76, Line 148:

    No space after a cast

    Done

To view, visit change 25373. To unsubscribe, or for help writing mail filters, visit settings.