Patch Set 1:

LGTM, but some reason you didn't look at I2C1?

There is some HW error on touchscreen cable, which goes to I2C1.
So even the touchscreen device is not added into the device tree yet.

I didn't look at I2C CLK on I2C1, but I assume the rise time / fall time might change after we use the new cable in the next build?
So let's leave the tuning work for I2C1 to later time.

View Change

To view, visit change 34559. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id98079e717f0db3fdcb88f85e45693925d11d7fd
Gerrit-Change-Number: 34559
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Chen <philipchen@google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg@chromium.org>
Gerrit-Reviewer: Philip Chen <philipchen@google.com>
Gerrit-Reviewer: Shelley Chen <shchen@google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Wed, 24 Jul 2019 22:48:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment