Attention is currently required from: Raul Rangel, Marshall Dawson, Matt Papageorge, Karthik Ramasubramanian.

View Change

2 comments:

• File src/vendorcode/amd/fsp/cezanne/pcie_routing_hob.h:

  • Patch Set #1, Line 38: static inline const struct pcie_routing_info *get_pcie_routing_info(unsigned int devfn)

    i wouldn't put the two functions here in a header in the vendorcode directory, but move them to the soc directory

  • Patch Set #1, Line 43: fsp_find_extension_hob_by_guid

    since this function call is rather expensive in terms of time, i wouldn't do the call for every irq number calculation. maybe use a static pointer and only do the call if it's NULL. at least for the acpi table generation that was moved from fsp to native coreboot code for picasso it was faster to generate the ssdt in coreboot and just ignore the hob than finding and copying the hob and that was just one call

To view, visit change 52869. To unsubscribe, or for help writing mail filters, visit settings.