[coreboot-gerrit] Change in coreboot[master]: lib/Makefile.inc: fail build when SPD would be empty

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45131 )

Change subject: lib/Makefile.inc: fail build when SPD would be empty
......................................................................

Patch Set 14:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45131/14/src/lib/Makefile.inc 
File src/lib/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/45131/14/src/lib/Makefile.inc@360 
PS14, Line 360: test -n "$(SPD_SOURCES)" || \
              : 	    (echo "HAVE_SPD_BIN_IN_CBFS is set but SPD_SOURCES is empty" && exit 1)
> In my opinion, we should allow a board to have empty SPD_SOURCES even when HAVE_SPD_IN_CBFS is set. […]

I'd rather avoid getting such incomplete states of board variants into the tree. I expect boards that make it into master to be able to boot, even if half of the features (e.g. Wi-Fi, touchpad, touchscreen, suspend and resume...) don't work. I don't mind if the initial commit adds just a single SPD source, and the rest get added later.