9 comments:
File src/soc/mediatek/mt8192/dramc_pi_basic_api.c:
Patch Set #41, Line 4037: dram_freq_grp
Add const modifier, and i'd prefer to keep it for shorter name, ok?
Done
Patch Set #41, Line 4072: rodt_tracking_mck
remove it now.
Done
Patch Set #41, Line 4080: ac_tim.datlat
update codes: […]
Done
File src/soc/mediatek/mt8192/dramc_pi_main.c:
jesd209-4 spec term tRFCAB, so change to TRFCAB_?
Ack
Actually, we may use actiming 1800 mapping to 1600 freq, so define the enum.
Ack
Patch Set #41, Line 42: ptRFCab_Opt
Follow jesd spec, we'd prefer to use this style for clear name. […]
How about we add a comment?
struct optimize_ac_time *ptrf_cab_opt; /* tRFCab */
File src/soc/mediatek/mt8192/dramc_pi_main.c:
SET32_BITFIELDS(&ch[chn].ao.shu_ac_time_05t, SHU_AC_TIME_05T_TRFC_05T,
trfc_05t);
Format it like this:
SET32_BITFIELDS(&ch[chn].ao.shu_ac_time_05t,
SHU_AC_TIME_05T_TRFC_05T, trfc_05t);
SET32_BITFIELDS(&ch[chn].ao.shu_ac_time_05t, SHU_AC_TIME_05T_TRFCPB_05T,
trfrc_pb05t);
Same
File src/soc/mediatek/mt8192/include/soc/dramc_ac_timing.h:
"T" is an standard clock interval, we'd prefer to keep the upper case for more clear. […]
Ack
To view, visit change 44713. To unsubscribe, or for help writing mail filters, visit settings.