View Change

4 comments:

• File src/mainboard/sifive/hifive-unleashed/flash.c:

  • Patch Set #29, Line 35: .data_proto = SPI_PROTO_Q,

    That should read MSEL and determine the boot mode. If running in single bit mode use SPI_PROTO_S.

    These codes are for HiFive Unleashed, the hardware link as QPI, and using SPI here only makes the performance worse, no need

  • Patch Set #29, Line 42: initialize_spi_flash_mmap(

    That should read MSEL and determine the boot mode. […]

    These codes used for HiFive Unleashed. This board doesn't have that much choice.

• File src/soc/sifive/fu540/spi.c:

  • Patch Set #29, Line 59: }

    That should implement […]

    This code is too heavy.
    Here is just mapping flash to memory space

• File src/soc/sifive/fu540/spi_flash.c:

  • Patch Set #29, Line 52: spi_txrx(spictrl, command_enable);

    Should use generic spi_xfer()

    spi-generic.c is too heavy.
    Here is just mapping flash to memory space

To view, visit change 30466. To unsubscribe, or for help writing mail filters, visit settings.