Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39601 )
Change subject: soc/intel/xeon_sp: Refactor code to allow for additional CPUs types ......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39601/6/src/soc/intel/xeon_sp/bootb... File src/soc/intel/xeon_sp/bootblock.c:
https://review.coreboot.org/c/coreboot/+/39601/6/src/soc/intel/xeon_sp/bootb... PS6, Line 38: ,
Removing of this is a clean-up, that should go to a separate patch. […]
Ack
https://review.coreboot.org/c/coreboot/+/39601/6/src/soc/intel/xeon_sp/inclu... File src/soc/intel/xeon_sp/include/soc/iomap.h:
https://review.coreboot.org/c/coreboot/+/39601/6/src/soc/intel/xeon_sp/inclu... PS6, Line 48:
Addition of this code should go to a dedicated patch, so this patch can stick to its commit message.
Ack
https://review.coreboot.org/c/coreboot/+/39601/6/src/soc/intel/xeon_sp/skx/i... File src/soc/intel/xeon_sp/skx/include/soc/pmc.h:
https://review.coreboot.org/c/coreboot/+/39601/6/src/soc/intel/xeon_sp/skx/i... PS6, Line 2: * This file is part of the coreboot project.
This file should be a rename from src/soc/intel/xeon_sp/include/soc/pmc.h, instead of a new file.
Ack