Patch Set 14:

Patch Set 14:

Patch Set 14:

Patch Set 14: Code-Review+1

Are we heading towards creating all PCI APIs with and without _always like been done for read_resources()?

I believe our original goal is to block probe function for all other devices except the one marked as "mandatory" in devicetree.cb right ? @Ron

Some of us (Aaron, Nico, me) seem to be much against (that original goal or approach) of partial PCI probing/enumeration due the undesirable side-effects mentioned along the review comments here. Furthermore, some of us seem to agree the real problem is with the resource allocation and not the PCI enumeration part.

if we divide the original definition of PCI enumeration then it combination of discovering the device, marking devices numbering and allocate the resource, enabling resource.
Not in static world we really don't have to do PCI device discover unless its on PCI-E root ports so resource allocation might be only significant things we have in hand right now. isn't it?

The PCI subsystem has always had separation of enumeration and resource allocation. It is only this development of "MINIMAL_PCI_SCANNING" where that was forgotten.

I think with #13 we reached some agreement that complete PCI enumeration is not harmful. I hope from now on this commit could concentrate only on addressing the somewhat urgent problem of PCI resource allocation.

As for any arguments about boot-time enhancements that could be achieved by partial PCI enumeration, let's just delay that discussion and development to another commit.

View Change

To view, visit change 36221. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2073d9f8e9297c2b02530821ebb634ea2a5c758e
Gerrit-Change-Number: 36221
Gerrit-PatchSet: 14
Gerrit-Owner: ron minnich <rminnich@gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Jeremy Soller <jeremy@system76.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <lean.sheng.tan@intel.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
Gerrit-Reviewer: Shelley Chen <shchen@google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Thu, 31 Oct 2019 06:54:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment