9 comments:
Patch Set #2, Line 9: X10SLM-F
X10SLM+-F
Done
Patch Set #2, Line 10: X10SLM-LN4F
X10SLM+-LN4F
Done
File src/mainboard/supermicro/x10slm/Kconfig:
Patch Set #2, Line 20: config BOARD_SPECIFIC_OPTIONS
This options here are sorted alphabetically, and it would be nice to […]
I changed the order to make it more structed actually, such as putting the superio chips together. Honestly I don't know if there is a sorting convention for these listings.
select MAINBOARD_HAS_LPC_TPM
select MAINBOARD_HAS_TPM2
Since this TPM config affects the code flow, and it's untested at least […]
Done
File src/mainboard/supermicro/x10slm/Kconfig.name:
Patch Set #2, Line 3: config BOARD_SUPERMICRO_X10SLM_PLUS_LN4F
Small nit: it would be nice to have a blank line between the two configs.
Done
File src/mainboard/supermicro/x10slm/gpio.c:
Please put solely formatting changes in a separate patch.
Done
that open brace { should be on the previous line
Done
that open brace { should be on the previous line
Done
that open brace { should be on the previous line
Done
To view, visit change 35163. To unsubscribe, or for help writing mail filters, visit settings.