Attention is currently required from: Cliff Huang, David Ruth, Lance Zhao, Paul Menzel, Subrata Banik, Subrata Banik, Tim Wawrzynczak.
7 comments:
Patchset:
Hi, I have a very general question: why is this information put into the firmware?
Is it chip or board specific?
File src/acpi/acpigen.c:
Patch Set #6, Line 1968: acpigen_write_byte(bytes[i]);
Is this valid AML? I would expect a Buffer() object around the bytes.
What does the decompilation look like?
File src/drivers/wifi/generic/acpi.c:
Why the weak function? Wouldn't it be an error to select USE_MTCL without
a proper implementation?
Patch Set #6, Line 591: CONFIG(USE_MTCL)
Putting this first would allow the compiler/linker to eliminate the other
checks, in case it's disabled.
Patch Set #6, Line 592: uint8_t mtcl_package[sizeof(struct wifi_mtcl)];
Why not declare a `struct wifi_mtcl`?
File src/vendorcode/google/chromeos/mtcl.c:
What is chromeos specific about this?
Patch Set #6, Line 59: if (mtcl_bin_len != sizeof(struct wifi_mtcl)) {
If this function knows `struct wifi_mtcl` why isn't it used in the signature?
To view, visit change 80170. To unsubscribe, or for help writing mail filters, visit settings.