Attention is currently required from: Jason Nien, Karthik Ramasubramanian, Martin L Roth, Paul Menzel.

View Change

2 comments:

• Commit Message:

  • Patch Set #3, Line 12: From https://review.coreboot.org/c/coreboot/+/54924:

    git operates with the hashes (74bce48f1d445053b217913df79a77dfe286e893), so I’d use that.

    Done

  • Patch Set #3, Line 13:

      > The default state for the IRQ lines when the eSPI controller comes
      > out of reset is high. This is because the IRQ lines are shared with
      > the other IRQ sources using AND gates. This means that in order to
      > not cause any spurious interrupts or miss any interrupts, the
      > IO-APIC must use a low polarity trigger.
    

    Remove the trailing two spaces?

    Did you mean the leading spaces? I removed them.

To view, visit change 78137. To unsubscribe, or for help writing mail filters, visit settings.