Attention is currently required from: Jérémy Compostella.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79738?usp=email )
Change subject: smmstorev2: Load the communication buffer at SMM setup
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/smmstore/smi.c:
https://review.coreboot.org/c/coreboot/+/79738/comment/75ecbb46_43626169 :
PS1, Line 88: if (base == 0 || size == 0)
: return SMMSTORE_RET_FAILURE;
This check is not needed as smmstore_init does something similar.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79738?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I94dce77711f37f87033530f5ae48cb850a39341b
Gerrit-Change-Number: 79738
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Comment-Date: Wed, 27 Dec 2023 20:25:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment