8 comments:
Patch Set #7, Line 7: mb/ocp/deltalake: Send OEM IPMI command for CMOS clear when RTC failure is detected
Maybe below summary is shorter:
mb/ocp/deltalake: Send OEM IPMI command for CMOS clear on RTC failure
When RTC failure is detected,
send IPMI OEM command to issue CMOS clear.
This is to let the payload (LinuxBoot) do some handling.
Please re-flow for 75 characters per line.
File src/mainboard/ocp/deltalake/ipmi.h:
Patch Set #7, Line 16: #define VALID_BIT (1 << 7)
Please align the values with spaces to the column of the block above.
Patch Set #7, Line 19: #define IS_CMOS_AND_VALID_BIT(x) ((x)&CMOS_BIT && (x)&VALID_BIT)
I’d left align the names.
File src/mainboard/ocp/deltalake/ipmi.c:
Patch Set #7, Line 122: the CMOS clear bit are both set from the response BootMode byte. */
Please align to the word *IPMI* above.
Pleas remove the blank line.
Patch Set #7, Line 150: printk(BIOS_INFO, "IPMI CMOS clear requested\n");
Maybe elaborate: … because CMOS data is invalid.
Patch Set #7, Line 151: return CB_SUCCESS;
Please add a blank line above.
To view, visit change 43005. To unsubscribe, or for help writing mail filters, visit settings.