Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48677 )
Change subject: kconfig: allow for optional source with osource
......................................................................
Patch Set 2:
We still have the site-local/Kconfig case, so not sure if I can get rid of this entirely. I split off the addition of the osource usage into another CL to see if that makes the linter happy.
Ah, `site-local`... Is that the only one? I guess that could
also be solved easily by creating an empty file there if none
exists?
I'm just wondering if it's worth the hassle to retrofit
`osource`. But, that's your call.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48677
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I71fbcfc1807e7398da250ddf1e47f6530345e0b5
Gerrit-Change-Number: 48677
Gerrit-PatchSet: 2
Gerrit-Owner: Jack Rosenthal
jrosenth@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Fri, 18 Dec 2020 17:48:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment