I think the "touchpad" is not a chromeos specific thing, so this is probably not the right place (any linux kernel would need it right?)

Please move the gpio_ouptut to mainboard.c, as

  static void configure_touchscreen(void) {
if (....)
gpio_output()...
}
  static void mainboard_init() {
...
configure_touchscreen();
...
}

View Change

To view, visit change 43319. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I069f5ef3e9477410d5349e5a702a4fbc14c201ed
Gerrit-Change-Number: 43319
Gerrit-PatchSet: 1
Gerrit-Owner: Magf - <magf@bitland.corp-partner.google.com>
Gerrit-Reviewer: Chen-Tsung Hsieh <chentsung@chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Casper Chang <casper.chang@bitland.corp-partner.google.com>
Gerrit-CC: Yu-Ping Wu <yupingso@google.com>
Gerrit-Comment-Date: Thu, 09 Jul 2020 08:55:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment