only had a very brief look at the patch
1 comment:
File src/superio/fintek/f71808a/f71808a_multifunc.c:
if (conf->configuration_port_select_0x27) {
pnp_write_config(dev, CONFIGURATION_PORT_SELECT,
conf->configuration_port_select_0x27);
}
This smells like a recipe for disaster to me. Changing the SIO config interface base address (I haven't seen a board where this was needed) will likely break SIO access and the other case would be that the change would never be applied to the SIO. So I don't see a reason to write the PORT_4E_EN bit.
If your intention is to just make PWOK_MODE configurable, then only change that bit instead of the full register.
To view, visit change 32376. To unsubscribe, or for help writing mail filters, visit settings.