Attention is currently required from: AtomicFS, Stefan Reinauer.
View Change
1 comment:
Commit Message:
Patch Set #1, Line 9:
Currently there is different behavior between using short and long
option. Long option causes Segmentation fault.
I think it is safe just to say the flag `has_arg` was mistakingly set to `0` while the option apparently takes an argument (`:` in optstring and also the help text says so) and this patch fixes the undefined behaviour.
The exact behaviour could differ as the pointer to the argument might AFAIK become undefined when `has_arg` is set to `0`. Hence the segfaults.
To view, visit change 80432. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7d5c31c2b1da544cb73d9e213d463332fcdba7df
Gerrit-Change-Number: 80432
Gerrit-PatchSet: 1
Gerrit-Owner: AtomicFS
Gerrit-Reviewer: Jan Samek <jan.samek@siemens.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune@9elements.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: Vojtěch Veselý <vojtech.vesely@9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: AtomicFS
Gerrit-Attention: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Comment-Date: Fri, 09 Feb 2024 12:03:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment