Martin Roth (martinroth@google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12804
-gerrit
commit 65a810c665fc053f090730f26920ee5aa10682d2 Author: Martin Roth martinroth@google.com Date: Sat Dec 26 13:33:09 2015 -0700
Documentation: Add information about patches from other git repos
This is more tribal knowledge that I don't think I've seen written down anywhere else. It's not a huge issue, but when looking through the git log, it helps to be able to differentiate the information from the old gerrit with the information from the new one.
Change-Id: I7993bda1e9aab79dc26940aaba9ddc52382ed0df Signed-off-by: Martin Roth martinroth@google.com --- Documentation/gerrit_guidelines.md | 12 ++++++++++++ 1 file changed, 12 insertions(+)
diff --git a/Documentation/gerrit_guidelines.md b/Documentation/gerrit_guidelines.md index 3140ff5..3a5f7fc 100644 --- a/Documentation/gerrit_guidelines.md +++ b/Documentation/gerrit_guidelines.md @@ -236,6 +236,18 @@ request. For major problems where the change doesn’t work as intended or breaks other platforms, the change really needs to go into the original patch.
+* When bringing in a patch from another git repo, update the original +git/gerrit information by prepending the lines with 'Original-'. Marking +the original text this way makes it much easier to tell what changes +happened in which repository. This applies to these lines, not the actual +commit message itself: + Commit-Id: + Change-Id: + Signed-off-by: + Reviewed-on: + Tested-by: + Reviewed-by: +
Expectations contributors should have: --------------------------------------