8 comments:
File src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam0.asl:
/*
* This file is part of the coreboot project.
*
* Copyright (C) 2020 Intel Corporation
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; version 2 of the License.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*/
There is some general clean-up of license headers going on. […]
Updated.
Patch Set #15, Line 18: Name (STA0, Zero)
Nit: Add an empty line between 2 entities(Name, Method, Device etc.). Here and the rest of the CL.
Updated.
Nit: space between ',' and 1.
Updated.
IF(STA1)
{
/* Power signal are already ON */
/* Assert Reset */
CTXS(GPP_D15)
Sleep(5) /* 5 us */
/* Deassert Reset */
STXS(GPP_D15)
Sleep(5) /* 5 us */
}
ELSE
{
PON()
/* Assert Reset */
CTXS(GPP_D15)
Sleep(5) /* 5 us */
/* Deassert Reset */
STXS(GPP_D15)
Sleep(5) /* 5 us */
}
This can be re-flowed as […]
Updated.
Patch Set #15, Line 59: Store(1,STA0)
Can we not use ASL2.0? i.e. […]
Updated
IF(STA1)
{
/* Do nothing since the other sensor is ON */
}
ELSE
{
POFF()
}
Same comment like in line 58.
Updated
}
}
}
})
}
Nit: Extra Indentation on all these lines.
Updated.
File src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam1.asl:
Please apply all the comments as in the cam0. […]
Updated
To view, visit change 39360. To unsubscribe, or for help writing mail filters, visit settings.