Attention is currently required from: Shelley Chen, Ravi kumar, Sajida Bhanu, mturney mturney.
View Change
1 comment:
Patchset:
Patch Set #32:
Why Macronix? Are we planning to use that for Herobrine? (This would be the first I heard of us using them on any Chrome OS device...)
Last I heard was that Herobrine rev0 was supposed to reuse the Trogdor rev2 I/O board, and on my schematics that is listed as GigaDevice. I would suggest you at least leave the Kconfigs for Winbond and GigaDevice in there, because we tend to use those two very often. (If you're using Macronix on your IDP then feel free to add that in addition, but I don't think you should remove the other too.)
To view, visit change 50583. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I505ee95d9f2ca16baf244135b3e2e8fe72f93491
Gerrit-Change-Number: 50583
Gerrit-PatchSet: 32
Gerrit-Owner: Ravi kumar <rbokka@codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Sajida Bhanu <sbhanu@codeaurora.org>
Gerrit-Reviewer: Shelley Chen <shchen@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney@codeaurora.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka@qualcomm.corp-partner.google.com>
Gerrit-Attention: Shelley Chen <shchen@google.com>
Gerrit-Attention: Ravi kumar <rbokka@codeaurora.org>
Gerrit-Attention: Sajida Bhanu <sbhanu@codeaurora.org>
Gerrit-Attention: mturney mturney <mturney@codeaurora.org>
Gerrit-Comment-Date: Tue, 04 May 2021 00:01:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment