Attention is currently required from: Felix Held.
View Change
1 comment:
Patchset:
Patch Set #6:
i don't see how this patch would break things and i verified this on a picasso system to work. […]
yep, this commenting out does allow me to get as far as I had previously gotten.
(I actually replaced the power_off_aoac_device with a printk so I could see that it fires and where in the process) results:
[SPEW ] scan_static_bus for Root Device
[DEBUG] CPU_CLUSTER: 0 enabled
[DEBUG] DOMAIN: 0000 enabled
[DEBUG] MMIO: fedc4000 enabled
[DEBUG] MMIO: fedc5000 enabled
[DEBUG] MMIO: fedc9000 disabled
[DEBUG] MMIO: fedca000 disabled
[DEBUG] MMIO: fedce000 disabled
[DEBUG] MMIO: fedcf000 disabled
[INFO ] power_off_aoac_device(FCH_AOAC_DEV_EMMC)
[DEBUG] MMIO: fedd5000 disabled
[DEBUG] DOMAIN: 0000 scanning...
To view, visit change 77990. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5453b69df776d2ce1f3be11e37cd26c8c64f0cd5
Gerrit-Change-Number: 77990
Gerrit-PatchSet: 6
Gerrit-Owner: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred@gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk@gmail.com>
Gerrit-Reviewer: Jason Nien <jason.nien@amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth@amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot@gmail.com>
Gerrit-CC: Marty E. Plummer <hanetzer@startmail.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Comment-Date: Thu, 28 Sep 2023 00:49:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter@mailbox.org>
Comment-In-Reply-To: Felix Held <felix-coreboot@felixheld.de>
Gerrit-MessageType: comment