Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41214 )
Change subject: mb/google/volteer: Reorganize audio codecs ......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41214/15/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/volteer/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/41214/15/src/mainboard/google/volte... PS15, Line 8: register "irq" = "ACPI_IRQ_EDGE_HIGH(GPP_F8_IRQ)" I am configuring it in halvor project. It is register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_F8)" in the old baseboard. Should it be ACPI_GPIO_IRQ_EDGE_BOTH or ACPI_GPIO_IRQ_EDGE_HIGH? Thank you.
Ref: https://review.coreboot.org/c/coreboot/+/41214/15/src/mainboard/google/volte...