Patch set 6:Code-Review +2

View Change

3 comments:

• Commit Message:

  • Patch Set #6, Line 20: FMAP%@0x1000 0x800

    nit: I feel conceptually this would look better as

     FMAP@0x1000% 0x800

    because alignment is a property of the offset, not the name. (For sections with automatic offset it would still be 'FMAP%', or 'COREBOOT(CBFS)%'.) But that might just be a matter of taste.

• File util/cbfstool/fmap_from_fmd.c:

  • Patch Set #6, Line 39: Non-CBFS

    nit: doesn't really have anything to do with CBFS?

• File util/cbfstool/fmd_parser.y:

  • Patch Set #6, Line 112: $$.v = $1.v | $3.v;

    I am unclear why this is $1 and $3 here but $1 and $2 in the seemingly equivalent case above. But I also have no idea how yylex works.

To view, visit change 37262. To unsubscribe, or for help writing mail filters, visit settings.