Patch Set 5:

Just a note as I have not looked at this in detail yet but some of these acpigen sequences are similar to ones I am adding helpers for: https://review.coreboot.org/c/coreboot/+/41985

Your use cases look a bit different and the functions might need different variants than what these use (string vs operator, etc) but it might be useful to see if any of the acpigen you are using could be similarly extracted.

If we had an acpi data type abstraction we could condense some of these multiple functions that all do the same thing with different data types...

Gotcha, will rebase and see if I can use some of those (the more the better).

Perhaps something like a tagged union of ACPI data types?
enum asl_type {
    ASL_INTEGER,
    ASL_BYTE,
    ASL_STRING, 
    etc.
};

and struct asl_value {
     enum asl_type type;
     union {
         you get the idea
     };
};

View Change

To view, visit change 41894. To unsubscribe, or for help writing mail filters, visit settings.